Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: changed all jobs to use Xcode 14 #1909

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

NachoSoto
Copy link
Contributor

Now that Xcode 14 RC is out, we should make it the default for all the jobs moving forward.

@NachoSoto NachoSoto added the ci label Sep 15, 2022
@NachoSoto NachoSoto requested a review from a team September 15, 2022 17:02
@NachoSoto
Copy link
Contributor Author

Let's see if they all pass though 🍿

@NachoSoto
Copy link
Contributor Author

Ugh. Mac building fails because Xcode 14 doesn't include the new SDK, and so checking for swift's version is the wrong check... I'll downgrade that job for now.

Now that [Xcode 14 RC](https://discuss.circleci.com/t/xcode-14-rc-released/45334) is out, we should make it the default for all the jobs moving forward.
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.circleci/config.yml Show resolved Hide resolved
@NachoSoto NachoSoto merged commit 03b39fa into main Sep 19, 2022
@NachoSoto NachoSoto deleted the circle-ci-xcode-14 branch September 19, 2022 18:00
NachoSoto added a commit that referenced this pull request Sep 20, 2022
Looks like this broke in #1909. Not sure why it's not finding those simulators, but we can just run those old versions with an older Xcode for now.
NachoSoto added a commit that referenced this pull request Sep 21, 2022
Looks like this broke in #1909. Not sure why it's not finding those
simulators, but we can just run those old versions with an older Xcode
for now.
NachoSoto added a commit that referenced this pull request Sep 21, 2022
Reverted from #1909.

Long story short, we’re relying on `#if swift(>=5.7) to do the right thing regarding Xcode versions, Swift version, and SDK version, but the macOS SDK in Xcode 14 is not updated.
NachoSoto pushed a commit that referenced this pull request Sep 23, 2022
**This is an automatic release.**

### Bugfixes
* `Purchases.beginRefundRequest`: ensured errors are `PublicError`
(#1913) via NachoSoto (@NachoSoto)
* `PurchaseTesterSwiftUI`: fixed macOS target (#1915) via NachoSoto
(@NachoSoto)
### Other Changes
* `SnapshotTesting`: require version 1.9.0 to keep supporting iOS 12/13
tests (#1931) via NachoSoto (@NachoSoto)
* Fixed `tvOS` tests (#1928) via NachoSoto (@NachoSoto)
* `pre-commit` hook: also verify leftover API keys in `PurchaseTester`
(#1914) via NachoSoto (@NachoSoto)
* `CircleCI`: changed iOS 12/13 to use Xcode 13 (#1918) via NachoSoto
(@NachoSoto)
* `PurchaseTesterSwiftUI`: removed unnecessary `UIApplicationDelegate`
(#1916) via NachoSoto (@NachoSoto)
* `CircleCI`: changed all jobs to use Xcode 14 (#1909) via NachoSoto
(@NachoSoto)
* `Atomic`: added unit test to verify `value`'s setter (#1905) via
NachoSoto (@NachoSoto)
* `spm build` CI job: changed to release build (#1903) via NachoSoto
(@NachoSoto)
* `StoreKitUnitTests`: compile on iOS 11.0+ (#1904) via NachoSoto
(@NachoSoto)
* `Purchases`: only expose testing data on `DEBUG` (#1902) via NachoSoto
(@NachoSoto)
* `Integration Tests`: added test to verify re-subscription behavior
(#1898) via NachoSoto (@NachoSoto)
* `IntegrationTests`: simplified `testExpireSubscription` to fix flaky
test (#1899) via NachoSoto (@NachoSoto)
* `Integration Tests`: actually verify that entitlement is active
(#1880) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants